Skip to content

Require a usable receiving account before a back campaign is approved or goes live #85

Closed

Description

@JOY

Goal

Found by #30 (DOS/DOS.Me#1538): back campaigns can go live without a usable receiving account (design 2.1), so a campaign that succeeds has nowhere for backers to pay.

Requirements

Acceptance

  • pgTAP for back: refused without, allowed with; app tests for the editor.

Follow-up of #30.

Activity

  1. JOY commented on Nov 3, 2026

    @JOY
    ContributorAuthor

    claim: executor="Claude Code" session=8215cf02-bb63-45e8-9035-cde273c39f3a scope="give.transition_campaign (DOS.Me migration 20261106100000), apps/web campaign editor account section" branch=claude/85-back-require-account target=2026-11-05

  2. JOY commented on Nov 3, 2026

    @JOY
    ContributorAuthor

    checkpoint: session=8215cf02-bb63-45e8-9035-cde273c39f3a
    PRs opened into dev: DOS/DOS.Me#1549 (migration 20261106100000, head 01d70bbe) and #90 (head 614878f).
    Evidence so far: all 21 give pgTAP suites green locally (new back suite 45/45), beta-migration-history/writer tests green, Vitest 895 passed, typecheck and lint green.
    Next: CI and Supabase Preview, independent review, then acceptance to the PO.

  3. JOY commented on Nov 3, 2026

    @JOY
    ContributorAuthor

    checkpoint: session=8215cf02-bb63-45e8-9035-cde273c39f3a
    Ready for PO acceptance (not merged): DOS/DOS.Me#1549 head 97a64f0c (merge first) and #90 head 573b41c.
    Evidence: 21/21 give pgTAP suites green locally (new back suite 45/45); Supabase Preview, DOS Code Review CLEAN_PASS, claude-review pass on 97a64f0c; Give Lint + Build all apps pass and DOS Code Review CLEAN_PASS on 573b41c; Vitest 895 passed; independent subagent review: no P1, P2/P3 fixed or documented.
    Follow-up: #92 (recovery for live/suspended back campaigns whose account became unusable).

  4. JOY commented on Nov 3, 2026

    @JOY
    ContributorAuthor

    done: session=8215cf02-bb63-45e8-9035-cde273c39f3a
    Merged into dev by the PO: DOS/DOS.Me#1549 at 76ebaa9fb771deb804a65ba0ad0bf6b18992c2bf and #90 at c9d4a44.
    Beta: Supabase Preview on 76ebaa9f (Beta project) completed with success (check run 126023609472), so migration 20261106100000 is applied on Beta.
    Acceptance: pgTAP for back campaigns (refused without a usable account, allowed with one, send-back recovery), 45/45, plus all 21 give suites green; app Vitest for the editor account section and submit guard (895 passed); CI and DOS Code Review green on both PRs.
    Follow-up: #92 (recovery for live/suspended back campaigns, PO decision posted there).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions