Repository navigation
Standalone scheme types #1443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ole-alb
wants to merge
48
commits into
main
Choose a base branch
from
standalone-scheme-types
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Standalone scheme types #1443
Changes from all commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
9b30f8b
add lookup tables
ole-alb efff7e3
start impelemting types
ole-alb 055c808
Merge remote-tracking branch 'origin/main' into standalone-scheme-types
ole-alb 9d3ce51
add more type functionality
ole-alb 4f3d26e
add luts
ole-alb 1176bf7
add types to standalone
ole-alb b6c665d
fix type functionality
ole-alb 0993001
rebuild count_leaves test
ole-alb 35eaa8f
add lut for face-corner and corner-face
ole-alb a6cba74
add calculation of standalone pyramid contro volume
ole-alb 3b9b087
new name for helper function
ole-alb 40ffd20
add new test for reference coords
ole-alb c957d1c
fix reference coordinate issues
ole-alb 8b3b0d3
fix reference coords for standalone scheme
ole-alb 3599a72
cleanup
ole-alb 4d82579
add Assertions to check tet coords
ole-alb 02f257d
Merge remote-tracking branch 'origin/main' into standalone-scheme-types
ole-alb 66ef631
delete duplicated test
ole-alb 18ab26d
cleanup
ole-alb ff71c8f
delete duplicated test
ole-alb dc59084
fix debug print error
ole-alb 2822d28
remove unused value
ole-alb 38aff55
remove unused variable
ole-alb f6d5752
fix test
ole-alb 9beb28a
add function get_max_num_children
ole-alb 53ed5b1
Merge remote-tracking branch 'origin/max_num_children' into standalon…
ole-alb 7055935
fix merge error
ole-alb 36b197f
Merge remote-tracking branch 'origin/max_num_children' into standalon…
ole-alb 534a96b
disable test
ole-alb 2dc7999
implement new test logic
ole-alb 3ced503
Merge branch 'main' into standalone-scheme-types
ole-alb 303a496
add maybe_unused
ole-alb 684f4f6
apply suggestions from review
ole-alb 7128129
Merge branch 'main' into standalone-scheme-types
ole-alb 126d1ec
apply review
ole-alb 29fc2e0
switch are_family implementation
ole-alb ada3535
apply review
ole-alb 1aff0a3
Merge branch 'main' into standalone-scheme-types
lukasdreyer 999f327
Merge branch 'main' into standalone-scheme-types
Davknapp 88897b0
Merge branch 'main' into standalone-scheme-types
Davknapp c265fdc
Merge remote-tracking branch 'origin/main' into standalone-scheme-types
ole-alb c84c888
fix merge errors
ole-alb a999e41
clear bitset before setting it
ole-alb 6f43237
remove redundant OR
ole-alb fcec7f9
add documentation for LUTs
ole-alb 197e302
fix error for other compilers
ole-alb 7021775
make all LUTs inline constexpr
ole-alb df6347d
Merge branch 'main' into standalone-scheme-types
ole-alb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we Assert for something fo rthe other tree_classes, too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if we need that