Skip to content

Add Trixi.jl downstream test - #145

Merged
benegee merged 5 commits into
mainfrom
bg/downstream-test
Sep 28, 2026
Merged

benegee merged 5 commits into
mainfrom
bg/downstream-test

Conversation

@benegee

@benegee benegee commented Sep 28, 2026 •

Copy link
Copy Markdown
Collaborator

I would like to add a downstream test targeting Trixi.jl. This would allow to test new versions (in CI) before actually releasing them.

@benegee
benegee marked this pull request as ready for review September 28, 2026 11:59
@benegee

benegee commented Sep 28, 2026

Copy link
Copy Markdown
Collaborator Author

The downstream tests worked: https://github.com/DLR-AMR/T8code.jl/actions/runs/36401884708
After that I changed the workflow to workflow_dispatch only.

@benegee

benegee commented Sep 28, 2026

Copy link
Copy Markdown
Collaborator Author

I also changed the precompile step introduced in the last PR. I now use try / finalize to make sure that in the end at least T8code.jl loads successfully.

@JoshuaLampert

Copy link
Copy Markdown
Collaborator

Does the workflow_dispatch allow running the downstream tests on a PR or only after a PR was merged? It would be good if we could trigger the downstream tests to test a PR. We could, e.g., trigger it on a certain comment posted on a PR.

@benegee

benegee commented Sep 28, 2026

Copy link
Copy Markdown
Collaborator Author

My idea was

  • use Actions (top)
  • select the new workflow on the left (similar to current "Run tests")
  • "Run workflow"
  • specify the branch of the PR to be checked (and optionally the Trixi.jl branch)

@JoshuaLampert

Copy link
Copy Markdown
Collaborator

Ah, sounds good. I didn't know you can set the branch there, but for Spell Check for instance you can switch the branch. Then it probably also works for the downstream tests once this PR is merged.

@JoshuaLampert JoshuaLampert left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I lost a bit track: Are the errors we see in CI with the system MPI (e.g. for SYSTEM_MPI nightly job in both the "Precompile (nightly)" and the "Run Julia tests" steps) expected?

@benegee

benegee commented Sep 28, 2026

Copy link
Copy Markdown
Collaborator Author

LGTM! I lost a bit track: Are the errors we see in CI with the system MPI (e.g. for SYSTEM_MPI nightly job in both the "Precompile (nightly)" and the "Run Julia tests" steps) expected?

Yes, unfortunately.

The dedicated precompile step is required for Julia 1.14 because the behavior regarding failed precompilation was changed. We have to use Pkg.precompile(; skip_dependents=false) to precompile T8code, even if its direct dependency t8code_jll failed. Once it is precompiled, we can actually use it. We make sure using T8code actually works.

In the tests, precompilation is triggered again because Julia realizes not all packages in the project are available in the cache. That is why we see the errors.

The dedicated precompilation step is not required for Julia <1.14 but I decided to leave it in just to trigger the failure and to make sure using T8code actually works.

@benegee
benegee merged commit b6c67eb into main Sep 28, 2026
21 checks passed
@JoshuaLampert
JoshuaLampert deleted the bg/downstream-test branch September 28, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants