Repository navigation
Add Trixi.jl downstream test - #145
Conversation
this is what is actually required in the real tests
|
The downstream tests worked: https://github.com/DLR-AMR/T8code.jl/actions/runs/36401884708 |
|
I also changed the precompile step introduced in the last PR. I now use try / finalize to make sure that in the end at least T8code.jl loads successfully. |
|
Does the |
|
My idea was
|
|
Ah, sounds good. I didn't know you can set the branch there, but for Spell Check for instance you can switch the branch. Then it probably also works for the downstream tests once this PR is merged. |
JoshuaLampert
left a comment
There was a problem hiding this comment.
LGTM! I lost a bit track: Are the errors we see in CI with the system MPI (e.g. for SYSTEM_MPI nightly job in both the "Precompile (nightly)" and the "Run Julia tests" steps) expected?
Yes, unfortunately. The dedicated precompile step is required for Julia 1.14 because the behavior regarding failed precompilation was changed. We have to use In the tests, precompilation is triggered again because Julia realizes not all packages in the project are available in the cache. That is why we see the errors. The dedicated precompilation step is not required for Julia <1.14 but I decided to leave it in just to trigger the failure and to make sure |
I would like to add a downstream test targeting Trixi.jl. This would allow to test new versions (in CI) before actually releasing them.