Skip to content

fix: circular JSON in buyCrypto update response #3750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TaprootFreak wants to merge 1 commit into from
Closed

fix: circular JSON in buyCrypto update response #3750

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion src/subdomains/core/buy-crypto/process/services/buy-crypto.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,21 @@ export class BuyCryptoService implements OnModuleInit {
await this.updateCryptoRouteVolume([cryptoRouteIdBefore, entity.cryptoRoute?.id]);
if (dto.usedRef || dto.amountInEur) await this.updateRefVolume([usedRefBefore, entity.usedRef]);

return entity;
// reload without userData.kycSteps/users: TypeORM sets the inverse back-reference on those
// collections, producing a circular graph that breaks JSON serialization of the response
return this.buyCryptoRepo.findOne({
where: { id },
relations: {
buy: true,
cryptoRoute: true,
cryptoInput: true,
bankTx: true,
checkoutTx: true,
transaction: { user: { wallet: true }, userData: true },
chargebackOutput: true,
bankData: true,
},
});
}

private async changeRoute(entity: BuyCrypto, route: Buy | Swap) {
Expand Down