Repository navigation
Support multiple policy tags - #239
Merged
Merged
Conversation
asatwal
force-pushed
the
support-multiple-policy-tags
branch
from
September 7, 2026 16:26
1837295 to
c0376a5
Compare
mysteryGarlicPress
approved these changes
Sep 8, 2026
mysteryGarlicPress
left a comment
mysteryGarlicPress
left a comment
Contributor
There was a problem hiding this comment.
Happy to approve, however it would be good to have a safeguard against misspelled/missformed policy tag json. I presume:
- when json is wrong, the app wont start
- when policy tag does not exist, the update will fail
4 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Support mutiple policy tables defined as JSON in ENV Variable.
Trello ticket: https://trello.com/c/BxYQWdrR
Changes proposed in this pull request:
analytics_hidden_pii.yml fileis supportedBIGQUERY_POLICY_TAGENV variable