Skip to content

fix(linalg): make GPU scalar in-place ops correct on CUDA (#988) - #992

Merged
pcchen merged 2 commits into
masterfrom
fix/gpu-scalar-inplace-noncontig
Jul 9, 2026
Merged

fix(linalg): make GPU scalar in-place ops correct on CUDA (#988)#992
pcchen merged 2 commits into
masterfrom
fix/gpu-scalar-inplace-noncontig

ci: retrigger checks after retarget to master

3fda11f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 8, 2026 in 0s

32.95% (+1.10%) compared to dfe688b

View this Pull Request on Codecov

32.95% (+1.10%) compared to dfe688b

Details

Codecov Report

❌ Patch coverage is 11.62791% with 76 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.95%. Comparing base (dfe688b) to head (3fda11f).
⚠️ Report is 15 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/Tensor.cpp 4.00% 32 Missing and 16 partials ⚠️
src/linalg/iAdd.cpp 22.22% 4 Missing and 3 partials ⚠️
src/linalg/iDiv.cpp 22.22% 4 Missing and 3 partials ⚠️
src/linalg/iMul.cpp 22.22% 4 Missing and 3 partials ⚠️
src/linalg/iSub.cpp 22.22% 4 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #992      +/-   ##
==========================================
+ Coverage   31.84%   32.95%   +1.10%     
==========================================
  Files         230      230              
  Lines       33117    33109       -8     
  Branches    13846    13813      -33     
==========================================
+ Hits        10547    10910     +363     
+ Misses      15549    14832     -717     
- Partials     7021     7367     +346     
Components Coverage Δ
C++ backend 33.70% <11.62%> (+1.13%) ⬆️
Python bindings 25.15% <ø> (+1.11%) ⬆️
Python package 61.84% <ø> (ø)
Files with missing lines Coverage Δ
src/linalg/iAdd.cpp 37.50% <22.22%> (-12.50%) ⬇️
src/linalg/iDiv.cpp 33.33% <22.22%> (-10.42%) ⬇️
src/linalg/iMul.cpp 33.33% <22.22%> (-10.42%) ⬇️
src/linalg/iSub.cpp 37.50% <22.22%> (-12.50%) ⬇️
src/Tensor.cpp 22.59% <4.00%> (+0.60%) ⬆️

... and 38 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfe688b...3fda11f. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.