Skip to content

fix(Storage): check dtype in at<T> unconditionally (#965) - #978

Merged
yingjerkao merged 2 commits into
masterfrom
fix/storage-at-unconditional-dtype-check
Jul 6, 2026
Merged

fix(Storage): check dtype in at<T> unconditionally (#965)#978
yingjerkao merged 2 commits into
masterfrom
fix/storage-at-unconditional-dtype-check

fix(Storage): correct %d format for 64-bit args in at<T> bounds error…

32ad1e8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 5, 2026 in 1s

30.91% (+0.04%) compared to 32079a4

View this Pull Request on Codecov

30.91% (+0.04%) compared to 32079a4

Details

Codecov Report

❌ Patch coverage is 52.27273% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 30.91%. Comparing base (32079a4) to head (32ad1e8).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/backend/Storage_base.cpp 52.27% 10 Missing and 11 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #978      +/-   ##
==========================================
+ Coverage   30.87%   30.91%   +0.04%     
==========================================
  Files         229      229              
  Lines       34757    34759       +2     
  Branches    14409    14398      -11     
==========================================
+ Hits        10730    10745      +15     
+ Misses      16720    16708      -12     
+ Partials     7307     7306       -1     
Components Coverage Δ
C++ backend 32.24% <52.27%> (+0.04%) ⬆️
Python bindings 17.28% <ø> (ø)
Python package 59.41% <ø> (ø)
Files with missing lines Coverage Δ
src/backend/Storage_base.cpp 25.23% <52.27%> (+3.46%) ⬆️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32079a4...32ad1e8. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.