Skip to content

build(release): prepare Windows CUDA wheel metadata - #1119

Open
IvanaGyro wants to merge 3 commits into
codex/windows-pypi-wheelsfrom
codex/windows-cuda-release
Open

build(release): prepare Windows CUDA wheel metadata#1119
IvanaGyro wants to merge 3 commits into
codex/windows-pypi-wheelsfrom
codex/windows-cuda-release

Conversation

@IvanaGyro

@IvanaGyro IvanaGyro commented Jul 23, 2026

Copy link
Copy Markdown
Member

Stack

master → #1110 → codex/windows-msvc-cuda-stack (#1116 patch) → #1117 → #1118 → #1119 → #1113

Depends on #1118 and is the final implementation layer before workflow-only #1113.

Summary

  • teach the CUDA release-manifest rewrite to emit Windows PyPI runtime dependencies and disable unavailable cuQuantum packages;
  • preserve the existing Linux RUNPATH/auditwheel rewrite;
  • add platform-specific release-manifest tests and the release-only tomlkit dependency;
  • keep IPO enabled in the existing Linux release pipeline;
  • disable IPO for Windows CUDA release wheels because CUDA 13 device LTO cannot find the NVVM runtime reliably in the split PyPI toolkit layout;
  • explicitly keep IPO off in both CPU and CUDA editable-install commands so iterative builds remain incremental.

Compatibility

Windows metadata uses compatible-release pins for CUDA 13 and cuTENSOR. The Python loader then locates those declared distributions directly; it does not scan arbitrary system SDK roots.

Validation

  • pytests/prepare_cuda_release_test.py: 3 passed;
  • both editable Pixi tasks explicitly pass -DCMAKE_INTERPROCEDURAL_OPTIMIZATION=OFF;
  • Linux release metadata retains its prior LTO setting;
  • repository-pinned pre-commit hooks pass.

Part of #1114.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@IvanaGyro
IvanaGyro force-pushed the codex/windows-cuda-release branch from 6c6e614 to 4ade236 Compare July 23, 2026 00:53
@IvanaGyro
IvanaGyro marked this pull request as ready for review July 23, 2026 02:04
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4ade236e2c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread pixi.toml
IvanaGyro and others added 3 commits July 29, 2026 17:14
Teach the CUDA manifest rewrite about Windows runtime dependencies and wheel settings, cover both platform paths with tests, and enable IPO only for release builds.

Co-Authored-By: OpenAI Codex <codex@openai.com>
Co-Authored-By: OpenAI Codex <codex@openai.com>
Co-Authored-By: OpenAI Codex <codex@openai.com>
@IvanaGyro
IvanaGyro force-pushed the codex/windows-cuda-release branch from 628f4ca to bb23ef7 Compare July 29, 2026 09:15

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bb23ef7949

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

import prepare_cuda_release as release # noqa: E402


def _manifest():

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Rename the leading-underscore helper

Rename _manifest to a snake_case name without a leading underscore. The canonical repository contract referenced by AGENTS.md explicitly prohibits leading underscores in new identifiers, and this helper is newly introduced in the change.

AGENTS.md reference: AGENTS.md:L3-L3

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant