build(release): prepare Windows CUDA wheel metadata - #1119
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
6c6e614 to
4ade236
Compare
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4ade236e2c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
4ade236 to
97758c4
Compare
97758c4 to
628f4ca
Compare
Teach the CUDA manifest rewrite about Windows runtime dependencies and wheel settings, cover both platform paths with tests, and enable IPO only for release builds. Co-Authored-By: OpenAI Codex <codex@openai.com>
Co-Authored-By: OpenAI Codex <codex@openai.com>
Co-Authored-By: OpenAI Codex <codex@openai.com>
628f4ca to
bb23ef7
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bb23ef7949
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| import prepare_cuda_release as release # noqa: E402 | ||
|
|
||
|
|
||
| def _manifest(): |
There was a problem hiding this comment.
Rename the leading-underscore helper
Rename _manifest to a snake_case name without a leading underscore. The canonical repository contract referenced by AGENTS.md explicitly prohibits leading underscores in new identifiers, and this helper is newly introduced in the change.
AGENTS.md reference: AGENTS.md:L3-L3
Useful? React with 👍 / 👎.
Stack
master → #1110 → codex/windows-msvc-cuda-stack (#1116 patch) → #1117 → #1118 → #1119 → #1113Depends on #1118 and is the final implementation layer before workflow-only #1113.
Summary
Compatibility
Windows metadata uses compatible-release pins for CUDA 13 and cuTENSOR. The Python loader then locates those declared distributions directly; it does not scan arbitrary system SDK roots.
Validation
pytests/prepare_cuda_release_test.py: 3 passed;-DCMAKE_INTERPROCEDURAL_OPTIMIZATION=OFF;Part of #1114.