Repository navigation
fix(yggdrasil): localize town crowd names - #437
Open
CloudeaSoft wants to merge 1 commit into
Open
CloudeaSoft wants to merge 1 commit into
CloudeaSoft wants to merge 1 commit into
Conversation
CloudeaSoft
enabled auto-merge (squash)
October 20, 2026 03:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Town Crowd NPCs referenced name localization keys without corresponding text entries. Add dedicated
Mods.Everglow.TownCrowds.hjsonfiles for English and Simplified Chinese and point the name selector and existing test at that namespace.Retain fixed, seeded names and add 12 Chinese names of 2–4 characters with English pinyin equivalents, bringing the pool to 44 names. Both languages cover every candidate.
Validation:
dotnet build --verbosity quiet /p:WarningLevel=0— passed (10 existing dependency warnings, 0 errors).dotnet test --no-build --no-restore --verbosity quiet /p:WarningLevel=0— all 759 tests passed.git diff --check— passed.