Skip to content

fix(yggdrasil): localize town crowd names - #437

Open
CloudeaSoft wants to merge 1 commit into
1.4.4from
codex/town-crowd-name-localization
Open

CloudeaSoft wants to merge 1 commit into
1.4.4from
codex/town-crowd-name-localization

Conversation

@CloudeaSoft

Copy link
Copy Markdown
Member

Town Crowd NPCs referenced name localization keys without corresponding text entries. Add dedicated Mods.Everglow.TownCrowds.hjson files for English and Simplified Chinese and point the name selector and existing test at that namespace.

Retain fixed, seeded names and add 12 Chinese names of 2–4 characters with English pinyin equivalents, bringing the pool to 44 names. Both languages cover every candidate.

Validation:

  • dotnet build --verbosity quiet /p:WarningLevel=0 — passed (10 existing dependency warnings, 0 errors).
  • dotnet test --no-build --no-restore --verbosity quiet /p:WarningLevel=0 — all 759 tests passed.
  • Hjson parsing, all 44 name keys in both languages, 2–4 character Chinese additions, byte-level UTF-8 BOM check, and git diff --check — passed.
  • In-game name rendering has not been manually verified.

@CloudeaSoft
CloudeaSoft enabled auto-merge (squash) October 20, 2026 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant