Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ORCA226/227 domain coverage checks by evaluating the corresponding policy rules instead of policy objects, including rule state and exclusions.
Also updates ORCA230–232 to use rule-based evaluation and align the result logic with upstream ORCA. The checks now focus on whether multiple enabled custom rules target the same domain, while respecting domain exclusions. No matching custom rule is treated as valid, while overlapping rules are reported as informational.
Because upstream ORCA treats the absence of a matching custom policy as valid — the default protection still applies — these checks do not represent a high-risk failure condition in that scenario. For that reason, I also reduced the risk rating from High to Medium.
Tests:
Small note: The Pester test is currently failing in Invoke-AddUser.Tests.ps1 because Get-Tenants is not available in the test context. From what I can see, this is unrelated to the changes in this PR
closes #586