Repository navigation
Draft: Update PixelMaskMetric with masked-pixel diagnostics - #259
Draft
jeipollack wants to merge 8 commits into
Draft
jeipollack wants to merge 8 commits into
jeipollack wants to merge 8 commits into
Conversation
added 5 commits
September 30, 2026 18:54
- Add diagnostic attribute to RejectionPolicyConfig - Update rejection config section parser - Remove validation methods added to pipeline.py - Update config_test.py with new and improved test cases - Update fixtures and remove deprecated YAML fixtures
- Add validation for metric resource requirements and rejection policy configuration - Call configuration validation from the pipeline constructor - Update pipeline execution to consume the `QualityMetric.compute` diagnostics API - Apply rejection policies using their configured diagnostic - Move cross-section validation tests from config_test.py to pipeline_test.py - Update and extend pipeline test coverage for the revised validation and updated processing flow
jeipollack
force-pushed
the
254-pixel-mask-quality-metrics
branch
from
October 1, 2026 12:32
10796cf to
f4c89b1
Compare
added 3 commits
October 2, 2026 10:02
- Move dataset factory and context fixtures to conftest.py - Add test_utils module to store helpers for testing
- Add YAML fixture with pixel mask settings, without resources and rejection disabled
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR extends the PixelMaskMetric class to compute four diagnostics describing pixel-mask coverage across the image and within a configurable aperture around the source:
Closes #254
What’s changed
qc_metrics_pixel_masks_test.py.pipeline_test.pythat runs the pixel-mask metric.conftest.pyand moving thePSFDatasethelper to a newtest_utils.pymodule.How to test / verify
Check CI passes.
Review the implementation and test coverage, with particular attention to:
QualityMetric.compute()API andQualityControlResult.Scope
Changelog
Reviewer Checklist
develop, ormainfor release PRs)ruff)Next Steps / Notes (if applicable)
Next, the rejection policy will be implemented and tested for this quality metric.