Repository navigation
Replace mask_obscuration with pixel_mask(s) - #256
Merged
roryclaydon1994 merged 2 commits intoSep 18, 2026
Merged
Conversation
added 2 commits
September 16, 2026 17:21
- Replace metric_rejection_policy with rejection_policy for clarity - Clean up formatting and spacing in error messages
roryclaydon1994
approved these changes
Sep 18, 2026
roryclaydon1994
left a comment
There was a problem hiding this comment.
Review feedback
Looks like this is just a name change? Some attributes were added to the metric heading, but as these aren't used yet, I haven't tried to review this.
Contributor
Author
Hi @roryclaydon1994 , yes, that's correct. These changes were motivated from current feature work on defining pixel mask quality metrics. Because renaming touched so many files I thought it best to open a PR to enable a speedy and simple review. |
roryclaydon1994
deleted the
255-change-mask_obscuration-to-pixel_mask
branch
September 18, 2026 15:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Small refactor to rename
mask_obscurationtopixel_mask.Closes #255
What’s changed
mask_obscuration.pytopixel_masks.pyMaskObscurationMetrictoPixelMaskMetricmask_obscurationidentifier topixel_maskin metric and rejection policy configurationmetric_rejection_policytorejection_policyinvalidate_rejection_policy_metrics()How to test / verify
mask_obscurationreferencesScope
Changelog
Reviewer Checklist
develop, ormainfor release PRs)ruff)Next Steps / Notes
For now, rejection policies use the quality metric name as their identifier. This keeps the current one-to-one metric/policy configuration model simple. In the future, a rejection policy may require multiple metrics, in which case the configuration model may need to be extended.