Repository navigation
251 refactor expose public API for PSF model generation - #252
Merged
ChaitanyaChawak merged 9 commits intoSep 28, 2026
Merged
ChaitanyaChawak merged 9 commits into
ChaitanyaChawak merged 9 commits into
Conversation
jeipollack
force-pushed
the
251-refactor-expose-public-api-for-psf-model-generation
branch
2 times, most recently
from
September 16, 2026 08:50
6860593 to
c485d3c
Compare
- Introduce PSFDataset as the unified input container for PSF inference. - Update PSFInference to use PSFDataset for inference data. - Remove the deprecated prepare_inference_data method. - Update inference adapter construction and associated tests/fixtures. - Enforce the inference dataset schema and required positions/SED fields. - Eagerly load inference configuration during initialization. - Add validation for inference data types and shapes.
- Add generate_psf_model public API - Add unit test - Update out-of-date PSFInference class doc string
…sion - Define inference-specific optional dataset fields with INFERENCE_OPTIONAL_KEYS in constants.py - Update the INFERENCE_SCHEMA.optional_keys to use INFERENCE_OPTIONAL_KEYS - Update and add TensorFlow conversion tests for missing and None fields - Rename the MISSING sentinel to _MISSING - Add type hints to ensure_tensor to resolve a Pylance issue
jeipollack
force-pushed
the
251-refactor-expose-public-api-for-psf-model-generation
branch
from
September 28, 2026 12:46
57b626e to
de003b0
Compare
added 2 commits
September 28, 2026 16:01
… inference dataset fields
ChaitanyaChawak
deleted the
251-refactor-expose-public-api-for-psf-model-generation
branch
September 28, 2026 14:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a new public API for PSF model generation and refactors the
PSFInferencedata contract by introducingPSFDataset, resulting in breaking API changes.Closes #251
What’s changed
PSFDatasetas the unified input container for PSF inference.PSFInferenceto usePSFDatasetfor inference data.generate_psf_models()public API for PSF model generation.prepare_inference_datamethod.positionsandseds.How to test / verify
psf_inference_test.pymodule.Scope
Changelog
Reviewer Checklist
develop, ormainfor release PRs)ruff)Next Steps / Notes (if applicable)