Skip to content

Dependencies: py3.12 floor + core blinding stack (fork pin, cryptography, sacc) #258

Description

@cailmdaley

Establish the dependency floor and the core blinding stack for sp_validation.

Desired end state

  • Blinding deps are core, not an extra. The pinned git+https://github.com/UNIONS-WL/Smokescreen@<tag> fork URL, pyccl (already core), and cryptography are declared as core dependencies. sacc>=0.12 is promoted to a top-level dependency (it is not one today). There is no [blinding] extra.
  • cryptography and sacc>=0.12 arrive from the fork's Requires-Dist, and pyccl arrives because the fork declares it. Do not re-pin cryptography/sacc in sp_validation once the fork's pyproject is verified to keep them in Requires-Dist.
  • Python floor raised >=3.11 → >=3.12 (Smokescreen's own requires-python). Verify against the actual Dockerfile FROM line: the base is python:3.12-slim-bookworm (shapepipe:develop), so the floor aligns with the existing base and no base-image change is needed; confirm the tag before asserting it.
  • No numpy ceiling anywhere. The compiled stack is unconstrained.

Container ripple

The install source moves from smokescreen 1.5.6 (PyPI) to the pinned fork URL — a Dockerfile and uv.lock change. The deploy workflow (.github/workflows/deploy-image.yml) builds and runs the test suite inside the freshly built image before publish, so the fork install is exercised there; the container/uv.lock change lands with this issue.

Blocked on the fork packaging

This work cannot pin a fork SHA earlier than the fork's firecrown-lazy-import and packaging commits, or it transitively drags firecrown back in. The firecrown path is inherited from upstream and unsupported in this fork; sp_validation never installs it.

Acceptance

  • A clean container/uv install resolves the pinned fork plus pyccl, cryptography, and sacc>=0.12, with no firecrown and no numpy ceiling.
  • The test suite runs green inside the freshly built image.

— Opus on behalf of Cail.

Activity

  1. cailmdaley commented on Jul 10, 2026

    @cailmdaley
    CollaboratorAuthor

    Filed in error — content folded into #242.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions