Repository navigation
Keep tile module logs after their temp run dirs are removed - #948
Open
cailmdaley wants to merge 1 commit into
Open
cailmdaley wants to merge 1 commit into
cailmdaley wants to merge 1 commit into
Conversation
A chunk's ShapePipe run dir is temp(), removed once tile_merge_cats has read it, and tile_vignets' run dir lives in the node-local store, so both runs' logs went with their dirs: the ngmix process logs that carry each chunk's `epoch cuts:` line and every per-object "ngmix failed" message were gone after any campaign, classic or single-allocation. Each rule now copies its run's logs/ files to $SP_RUN/logs/modules/<run name>/ before it exits, whatever its rc, without changing that rc. The shell change moves the params pin in tile_vignets and tile_ngmix, so land it at a campaign boundary. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01D8wdTpGpBtyK6uHwU7qWQW
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keeps the ShapePipe module logs of
tile_vignetsand the ngmix chunks after their run directories are deleted.tile_ngmix's chunk run directories aretemp(), so their logs were deleted aftertile_merge_cats. Those logs hold the per-chunk "epoch cuts:" summary and the per-object failures. They were lost under both launch modes, even withclean_tiles: false. This is how we couldn't diagnose the 23 objects lost under des_y6 weighting.Each of these jobs now copies its logs to
<tile>/logs/modules/<run>/before it exits, whatever its exit status. A failed copy only warns. The cost is about 180 KB per chunk.Test:
test_module_logs_outlive_their_run_dirsfails without the copy.Claude Opus 5.5 on behalf of Cail
🤖 Generated with Claude Code
https://claude.ai/code/session_012yfkBvkzPv33iJxXZ6jAxd