Skip to content

feat(editor): add optional arrow-key layer reordering - #523

Open
MelmacAlpha wants to merge 3 commits into
CoreBunch:mainfrom
MelmacAlpha:feat/editor-arrow-layer-reorder
Open

feat(editor): add optional arrow-key layer reordering#523
MelmacAlpha wants to merge 3 commits into
CoreBunch:mainfrom
MelmacAlpha:feat/editor-arrow-layer-reorder

Conversation

@MelmacAlpha

@MelmacAlpha MelmacAlpha commented Sep 10, 2026

Copy link
Copy Markdown

Summary

Adds optional / shortcuts for moving the selected layer one sibling position within its current parent on the canvas or Layers tree.

  • Reuses the existing layers.moveUp / layers.moveDown commands and the moveNode / moveNodes mutation path.
  • Adds Settings → Preferences → Layers panel → Move layers with Arrow keys, off by default.
  • Adds the new Arrow-key entries to the Settings → Shortcuts reference through the shared keybinding registry.
  • Moves multi-selected sibling layers as one ordered block in a single undo step; selections spanning different parents or containing a locked layer remain unchanged.
  • Ignores modifier keys, editable fields, inline text editing, and the Alt/Option inspect ladder.
  • Documents the preference and shortcut behavior.

Verification

  • bun run build
  • bun test — not fully green in the local sandbox; environment-dependent failures include temporary-file permission errors and ephemeral-port conflicts, outside this change.
  • bun run lint
  • Focused regression tests:
    bun test src/__tests__/spotlight/layersCommands.test.ts src/admin/spotlight/__tests__/shortcutDispatch.test.ts src/__tests__/settings/settingsSections.test.tsx src/__tests__/settings/settingsModal.test.tsx src/__tests__/architecture/keybindings-registry-single-source.test.ts

Checklist

  • Tests cover behavior changes.
  • Docs were updated when behavior, config, deployment, or public surfaces changed.
  • No compatibility shim was added for old pre-release behavior.
  • No secrets, local databases, uploads, or generated artifacts are included.

Assisted-by: OpenAI Codex

@MelmacAlpha
MelmacAlpha marked this pull request as ready for review September 10, 2026 22:47

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9dc2eebb53

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/admin/spotlight/commands/layers.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant