fix(tests): tolerate CRLF working-tree line endings in freshness and style gates - #516
Draft
tahayusab wants to merge 1 commit into
Draft
fix(tests): tolerate CRLF working-tree line endings in freshness and style gates#516tahayusab wants to merge 1 commit into
tahayusab wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows checkouts (autocrlf), three gates compare raw bytes against
line-ending-sensitive patterns and fail spuriously:
Root causes:
scripts/sync-plugin-bootstrap.tsbundles from on-disk sources; on a CRLFworking tree the CRLFs are carried into the bundle and JSON-escaped, so the
in-memory artifact diverges from the committed (LF) artifact even with no
source drift.
plugin-bootstrap-fresh.test.tscompares the committed artifactbyte-for-byte; a CRLF-checked-out file never equals the LF string.
siteExplorerPanel.test.tsxmatches a multi-line CSS selector block with aregex that hardcodes
\nline breaks.Changes:
bundleEntryso emitted artifacts stayplatform-independent (no-op on LF checkouts; committed artifacts unchanged).
\r?\n.Verified on a Windows / autocrlf checkout:
plugin-bootstrap-fresh1 pass,siteExplorerPanel40/40 pass (was 39 + 1 fail), no priorbootstrap:sync,git statusclean ongenerated/.bun run build+bun run lintgreen.