You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Retire the three unreachable postAiResponse helpers #259
apps/teams-bot/src/lib/teams-poster.ts:26 — postAiResponse → context.sendActivity (the file documents its own unreachability at lines 23-24)
Nothing imports any of them except github-poster.test.ts, so there's no live leak. The real path is the worker's PlatformAdapter, which is gated on shadow mode in packages/outpost/queue/src/handlers/ai-response.ts.
The problem is what happens next time someone needs a direct post. Each of these is one import away from being wired up, and none consults shadow mode, so the caller would silently bypass the gate — and docs/deployment.md:212 currently asks the author to remember by hand. That's the same shape as the bug #233 is fixing: enforcement by convention rather than by the predicate.
Two ways to go, and I lean toward the first:
Delete them. The PlatformAdapter path in the worker is the real one, and dead code that looks live is worse than no code.
Guard them, so a future caller inherits the check:
Activity
linear-code commentedon Sep 9, 2026
CPK-8285