Repository navigation
fix(app): enforce QR session expiry when reading the store - #115
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expiry depends exclusively on scheduled timers. After the process/event loop is suspended, a request can read a stale selected prompt before its delayed timer runs. Store an absolute deadline and enforce it on reads.
Validation: the added regression fails on upstream
9c982df1a16b734a49d8dd9d1c29b0e4b1b1805band passes with this change. The complete frontend Vitest suite and TypeScript check pass locally on Node 24.19.0.Prepared with AI assistance and independently reviewed by another agent before submission. Provider calls are mocked; this does not establish live model-provider behavior.
Combined integration checks pass: 249 Node tests, 157 Python tests, TypeScript, frontend lint (0 errors, 2 warnings), and the production workspace build. These combined results belong to the private integration branch; each PR also has its own focused regression and relevant suite results above. Live provider behavior is untested.
Independent AI review passed on this exact head. Nine isolated production-browser checks passed for the combined chat shell/key dialog and QR request flow; no page errors. No live provider calls were made.