Repository navigation
test(queue): stop the trim rate-limit test racing its own first trim - #473
Merged
Merged
Conversation
The opening publish trims after its XADD. With a 1 ms TTL, a pause over 1 ms between the two removed the entry the test then counted, about once in 2,400 runs under load. Let an opening publish start the interval and assert on the two entries after it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 40 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. CodeRabbit Verify
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TestRedisFactStream_TrimIsRateLimitedno longer fails at random. It failedUnit testson #471, which doesn't touch this package.The test uses a 1 ms TTL, and the first publish on a stream runs its trim after its
XADD. If more than 1 ms passes between the two, that publish removes its own entry, and the test finds one entry instead of two. A real TTL is minutes long, so this only affects the test.An opening publish now starts the trim interval, and the test asserts only on the two entries after it. Nothing is asserted about the opening entry, which may or may not survive.
Type of Change
Testing
task lintandtask testpass locally-race, no failures🤖 Generated with Claude Code