Repository navigation
Conversation
WalkthroughThe PR upgrades Go toolchain and multiple dependencies (notably github.com/conductorone/baton-sdk), removes redundant blank imports across connector files, updates resource call sites to use sdkResources, and changes a CreateAccount parameter type and adds a static interface assertion in server_user.go. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
ba23f57 to
046abf5
Compare
5f8d91c to
519671c
Compare
519671c to
88baa0c
Compare
Updates the CreateAccount method signature to use v2.LocalCredentialOptions instead of the deprecated v2.CredentialOptions, which was causing an "old account manager interface implemented" error after the SDK upgrade to v0.7.4. Also adds compile-time verification that userPrincipalSyncer implements the AccountManagerLimited interface.
|
Closing this because #44 is merged and it upgrades baton-sdk to a newer version. |
Summary
Build Status
go build ./...passes locallyCI Notes
Integration test fails due to missing CI secrets (no SQL Server instance configured). This is a pre-existing infrastructure limitation.