Repository navigation
[CXH-3498] - Docs: baton-github — add "when to use" guidance and document missing capabilities - #196
Conversation
Superseded — see the current review report for commit
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Superseded — see the current review report for commit
|
There was a problem hiding this comment.
No blocking issues found — see the full review report
luisina-santos
left a comment
luisina-santos
left a comment
There was a problem hiding this comment.
Holding this until the shared "Choose a GitHub connector" guide from CXH-3497 exists. That guide isn't written yet, and the parent issue requires all three connector pages to link it.
Once the guide is published, add the link to the note at the top of each page and merge these three PRs together:
- #196
- ConductorOne/baton-github-enterprise#33
- ConductorOne/baton-axiomatic-github-enterprise-cloud#16
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Superseded — see the current review report for commit
|
Superseded — see the current review report for commit
|
There was a problem hiding this comment.
No blocking issues found — see the full review report
Superseded — see the current review report for commit
|
Superseded — see the current review report for commit
|
There was a problem hiding this comment.
No blocking issues found — see the full review report
…or guide GitHub Enterprise documents only classic PAT and GitHub App auth, and GitHub Enterprise Cloud accepts only a GitHub App, so fine-grained PAT support is unique to this connector. The custom-domain pointer is replaced by the Choose a GitHub connector guide, which covers GHES and GHEC routing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Superseded — see the current review report for commit
|
Connector PR Review: [CXH-3498] - Docs: baton-github — add "when to use" guidance and document missing capabilitiesBlocking Issues: 0 | Suggestions: 2 | Threads Resolved: 0 Review SummaryThe PR changes only Security IssuesNone found. Correctness IssuesNone found. Suggestions
Resolved prior findings
Prompt for AI agentsReviewed commit: |
There was a problem hiding this comment.
No blocking issues found — see the full review report
INTENT
docs/connector.mdxwith when-to-use guidance: github.com orgs, one org per GitHub App or several orgs with one PAT, the only GitHub connector with fine-grained PAT support, and a link to the shared "Choose a GitHub connector" guide.org_role(sync + provision) to the Capabilities table; no enterprise roles, licenses, or last-activity.What changed
docs/connector.mdxonly: rewritten top note (links/baton/choose-github-connector; the custom-domain pointer to GitHub Enterprise is removed because the guide covers GHES and GHEC routing), new "Org roles" capability row, new EMU note under the provisioning paragraph.Verified in code
org_rolesync + provision:baton_capabilities.json(org_role entry),pkg/connector/org_role.go(Grants,Grant,Revoke)pkg/connector/invitation.go(CreateAccount->CreateOrgInvitation)pkg/connector/invitation.go(isEMUOrgError)token), GitHub App (app-id,org), multi-org (orgs):config_schema.jsonenterprise-slug,app-id,app-privatekey-path,installation-id).Open items
/baton/choose-github-connector, added in Add a guide for choosing a GitHub connector docs#632. Merge that PR first, or together with this one and the two sibling PRs ([CXH-3499] - Docs: baton-github-enterprise — say it covers GHES and GHEC, highlight unique capabilities, fix auth-option inconsistency baton-github-enterprise#33, ConductorOne/baton-axiomatic-github-enterprise-cloud#16), so the link doesn't 404.enterprise_roleimplementation exists in code (requires theenterprisesconfig) and is acknowledged, but it is not documented here.Fixes CXH-3498
🤖 Generated with AI