Skip to content

docs: update admin nav path and Add connector flow - #28

Merged
mindymo merged 1 commit into
mainfrom
docs/nav-and-create-connector-drawer
Sep 10, 2026
Merged

mindymo merged 1 commit into
mainfrom
docs/nav-and-create-connector-drawer

Conversation

@mindymo

@mindymo mindymo commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Summary

Two upstream product changes affect this connector's docs:

  • Admin nav reorg (ductone/c1#24648): the sidebar path is now Apps > Connectors, replacing Integrations > Connectors.
  • New Add connector drawer (ductone/c1#24933, ductone/c1#25052): the old 3-option "Add connector" flow (unmanaged app / managed app / new managed app + single owner) is replaced by a guided drawer: choose destination (new app / existing app) → optionally link to an application discovered from your identity provider → name/description → owners (multi-owner picker) → Add.

Both features are live in production. This PR brings the connector's own docs source in line with what's already merged in ConductorOne/docs (see ConductorOne/docs#527 and ConductorOne/docs#528), so the next sync doesn't reintroduce the stale flow.

Corrections were verified against the actual drawer code and applied directly to this file — not reapplied as a blind patch, since source docs can drift from what's synced into the docs site.

Test plan

  • Preview build looks correct

- Apps > Connectors replaces Integrations > Connectors in the admin
  nav (c1#24648).
- The Add connector walkthrough now reflects the new guided drawer:
  choose destination (new app / existing app) -> optional IdP link
  -> name/description -> owners -> Add (c1#24933, c1#25052).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

Connector PR Review: docs: update admin nav path and Add connector flow

Blocking Issues: 0 | Suggestions: 1 | Threads Resolved: 0
Criteria: Criteria status: loaded .claude/skills/ci-review.md from trusted base b3f1d1d4010d.
Review mode: full
View review run

Review Summary

Docs-only PR touching docs/connector.mdx: it renames the admin nav path from Integrations > Connectors to Apps > Connectors (3 occurrences) and rewrites the cloud-hosted Add connector steps to match the new guided drawer (destination, optional IdP app link, name/description, owners, Add). The full PR diff was scanned for security and correctness; there is no Go code, no go.mod/go.sum, and no config or provisioning change, so the connector implementation criteria do not apply. The rewritten step sequence is internally consistent, flows correctly into the existing Settings / Edit step, and no stale nav path or old-flow wording remains in docs/connector.mdx.

Security Issues

None found.

Correctness Issues

None found.

Suggestions

  • .claude/skills/connector/build-connector-docs.md:254 (also lines 262-277, 311, 319-323, 460, 542) — the doc-generation template still carries the old Integrations > Connectors nav path and the old 3-option flow (unmanaged app / managed app / new managed app) with a single-owner step and a final Next click, so regenerating or extending these docs from the skill would reintroduce exactly the staleness this PR fixes. Out of diff scope; medium confidence, and likely better as a follow-up than a change here.

Note: the machine-readable review-state marker could not be included in this comment because the CI shell blocked the JSON payload; the next review run will fall back to full mode rather than incremental.

Prompt for AI agents
Verify each finding against the current code and only fix it if needed.

## Suggestions

In `.claude/skills/connector/build-connector-docs.md`:
- Around lines 254 and 311: The template still instructs the reader to navigate to
  **Integrations** > **Connectors** in C1. Update both to **Apps** > **Connectors** to
  match the current C1 admin nav. Also update line 460 (Navigation paths guidance that
  uses **Integrations** > **Connectors** as its example) and the checklist item at line
  542 (Cloud-hosted tab uses **Integrations** > **Connectors** navigation).
- Around lines 262-277 and 319-323: The template's cloud-hosted Add connector steps still
  describe the retired 3-option flow (add to unmanaged app / add to managed app / create
  new managed app), a single-owner step with the email-notification note, and a final
  Click **Next** step. Replace with the current guided drawer sequence used in
  docs/connector.mdx lines 213-226: choose destination (**Create a new app** or **Add to
  an existing app**), optionally link to an application discovered from the identity
  provider (**Yes** and pick the app, or **No**), set **Name** and optional
  **Description**, click the pencil icon next to **Owners** to pick owners, then click
  **Add**, after which the connector is created and its configuration page opens.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking issues found.

@mindymo
mindymo merged commit eb428ec into main Sep 10, 2026
10 of 11 checks passed
@mindymo
mindymo deleted the docs/nav-and-create-connector-drawer branch September 10, 2026 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant