Skip to content

chore: bump version to 0.3.1 - #6

Merged
Acktarius merged 1 commit into
mainfrom
ack/dev
Aug 27, 2026
Merged

chore: bump version to 0.3.1#6
Acktarius merged 1 commit into
mainfrom
ack/dev

Conversation

@Acktarius

Copy link
Copy Markdown
Member

No description provided.

@Acktarius
Acktarius merged commit d3956ec into main Aug 27, 2026
2 checks passed
@roomote-conceal-network

roomote-conceal-network Bot commented Aug 27, 2026

Copy link
Copy Markdown

2 issues outstanding. See task

  • android/build.gradle:13,24 — library version/versionName still 0.2.8; version bump to 0.3.1 left the Android artifact metadata stale (thread)
  • CHANGELOG.md — release table stops at v0.2.8; no rows for v0.3.0/v0.3.1

Code review — chore: bump version to 0.3.1

# Severity File Line(s) Issue
1 🟡 Medium android/build.gradle 13, 24 Version bump incomplete: Android version/versionName pinned at 0.2.8, lagging the npm package (package.json is now 0.3.1). Consider deriving from package.json like ConcealCrypto.podspec does.
2 🟢 Low CHANGELOG.md 3-11 Release table has no entries for v0.3.0 or v0.3.1.

Otherwise the bump itself is consistent (package.json and both package-lock.json locations match, tag v0.3.1 exists, podspec reads the version from package.json).
Reviewed 80446ca

Comment thread package.json
{
"name": "react-native-conceal-crypto",
"version": "0.3.0",
"version": "0.3.1",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version bump is incomplete: android/build.gradle still pins the library version at 0.2.8 (version = '0.2.8' on line 13 and versionName "0.2.8" on line 24), so the Android artifact metadata now lags the npm package by three patch releases. Consider sourcing it from package.json (like ConcealCrypto.podspec already does) so future bumps stay in sync:

Suggested change
"version": "0.3.1",
"version": "0.3.1",

(along with updating android/build.gradle:13,24 to 0.3.1 in the same commit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant