Repository navigation
Resolve Test Failures after RNG update - #1412
Merged
Merged
Conversation
…hift search resolution and range. Adjust degree tolerance from 1 to 2. Fix eigenvalue bugs and adjust acceptable spread tolerance. Use relative Frobenius error in gram matrix test.
…just spectral norm constraint based on observed ground truth spectral norms. Small max_rankZ bug.
… based on ground truth spectral norm of grma matrix.
…mate_rotations and relative_viewing_directions. Fix reused index bug in test_self_relative_rotations. Add non-equator random rotation generator and use for order > 3 algos.
…and use mean_aligned_shift_error to account for global 3D translation ambiguity. Reduce Image count. Fix dtype passthrough bug and add test.
… with behavioral test.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## fix_rng #1412 +/- ##
==========================================
Coverage ? 90.07%
==========================================
Files ? 135
Lines ? 14997
Branches ? 0
==========================================
Hits ? 13508
Misses ? 1489
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
Kicking off the full CI to make sure we got everything. |
j-c-c
marked this pull request as ready for review
September 25, 2026 15:17
…l test. Fix to fine of shift_step resolution (unecessary). Increase image count for tests. Account for 180 degree self-commonline ambiguity in scl test.
j-c-c
changed the title
Collaborator
|
Looks like the failures are from the old numpy version. I'll merge in, patch that, and see where things land. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolving test failures in
fix_rngbranch.For each failing test file I am running a sweep over 10 rng seeds to find as many potential failures as possible. Then resolving the failures and re-running the sweep.