Skip to content

CMP-4616: Fix flaky TestScheduledSuiteNoStorage e2e test - #1369

Open
yuumasato wants to merge 1 commit into
ComplianceAsCode:masterfrom
yuumasato:fix-scheduled-suite-no-storage-flake
Open

CMP-4616: Fix flaky TestScheduledSuiteNoStorage e2e test#1369
yuumasato wants to merge 1 commit into
ComplianceAsCode:masterfrom
yuumasato:fix-scheduled-suite-no-storage-flake

Conversation

@yuumasato

@yuumasato yuumasato commented Aug 21, 2026

Copy link
Copy Markdown
Member

Summary

  • TestScheduledSuiteNoStorage validates that no PVCs are created when RawResultStorage is disabled — it tests storage behavior, not compliance outcome
  • The test only accepted ResultCompliant, but under cluster pressure from ~70 parallel tests the scan can return NON_COMPLIANT or ERROR, causing an immediate hard failure
  • Use WaitForSuiteScansStatusAnyResult accepting both COMPLIANT and NON_COMPLIANT
  • Move the PVC assertion after the suite completes, matching the pattern in TestScheduledSuitePlatformNoStorage

Test plan

  • e2e-aws-parallel CI job passes without TestScheduledSuiteNoStorage flaking

Jira: CMP-4616

🤖 Generated with Claude Code

TestScheduledSuiteNoStorage validates that no PVCs are created when
RawResultStorage is disabled. The test was brittle because it only
accepted ResultCompliant, but the no_netrc_files rule can return
NON_COMPLIANT or ERROR under cluster pressure from parallel tests.
Since the test validates storage behavior and not compliance outcome,
accept both COMPLIANT and NON_COMPLIANT results.

Also move the PVC assertion after WaitForSuiteScansStatusAnyResult so
it runs once the scan has actually completed, matching the pattern used
by TestScheduledSuitePlatformNoStorage.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-ci-robot

openshift-ci-robot commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

@yuumasato: This pull request references CMP-4616 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.1.0" version, but no target version was set.

Details

In response to this:

Summary

  • TestScheduledSuiteNoStorage validates that no PVCs are created when RawResultStorage is disabled — it tests storage behavior, not compliance outcome
  • The test only accepted ResultCompliant, but under cluster pressure from ~70 parallel tests the scan can return NON_COMPLIANT or ERROR, causing an immediate hard failure
  • Use WaitForSuiteScansStatusAnyResult accepting both COMPLIANT and NON_COMPLIANT
  • Move the PVC assertion after the suite completes, matching the pattern in TestScheduledSuitePlatformNoStorage

Test plan

  • e2e-aws-parallel CI job passes without TestScheduledSuiteNoStorage flaking

Jira: CMP-4616

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@github-actions

Copy link
Copy Markdown

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1369-6dfabb63106660ea58e4960a55e008541850a8a4

@openshift-ci

openshift-ci Bot commented Aug 21, 2026

Copy link
Copy Markdown

@guzalv: changing LGTM is restricted to collaborators

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci

openshift-ci Bot commented Aug 21, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guzalv, yuumasato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants