T3067 my compassion 18.0 migration

[NoeBerdoz]

[MIG] T3067: shared fields for the MyCompassion portal (Odoo 18)

This PR adds two shared fields that the MyCompassion portal needs after the old
website_sponsorship module was removed. The fields used to live in that module,
so they had to move to a base module that stays.

Please merge this PR first. The other two PRs below depend on these fields.

Key changes

• partner_salutation: add is_shown_on_public_forms on res.partner.title.
  This flag decides which titles (Mister, Madam, ...) are shown in public forms.
  A post-migration script seeds Mister and Madam so they keep showing.
• sponsorship_compassion: move legal_agreement_date onto res.partner
  (it lived in the deleted website_sponsorship) and show it on the partner form.
• Small test fixes for Odoo 18.

Related PRs (please review together)

This is one part of a 3-repo migration. The reviewer of this PR is also concerned
by the other two:

• compassion-modules (this PR): T3067 my compassion 18.0 migration #2108
• compassion-website: T3067 my compassion 18.0 migration compassion-website#341
• compassion-switzerland: T3067 my compassion 18.0 migration compassion-switzerland#1763

Merge order: compassion-modules first, then compassion-website, then compassion-switzerland.

[gemini-code-assist]

Code Review

This pull request introduces a new boolean field is_shown_on_public_forms to partner titles along with a post-migration script to seed default values. It also adds a legal_agreement_date field to partners, updates tests to use TransactionCase instead of SavepointCase, and corrects a relativedelta import. Regarding feedback, it is recommended to change the legal_agreement_date field from Datetime to Date to avoid potential timezone-shifting bugs.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[greptile-apps]

Confidence Score: 5/5

The touched areas are narrow and the changes align with the migration and test-compatibility goals.

No correctness issues were identified in the reviewed changes, and the updates are covered by targeted model, migration, view, and test adjustments.

T-Rex Logs

What T-Rex did

• T-Rex verified the base field state and migration impact, showing that FIELD_EXISTS changed from False to True, VIEW_CONTAINS_FIELD became True, and the DEFAULT_PUBLIC_TITLE_XMLIDS migration includes base.res_partner_title_mister and base.res_partner_title_madam, with SEEDED_VALUES indicating Mister and Madam are True and OTHER_TITLES_FORCED_TRUE remaining empty.
• T-Rex inspected the partner anonymization probe and observed before/after changes: field_defined_by_ast changed from False to True, anonymize flags were set, and legal_agreement_date_field_nodes_in_xml increased; the runtime was blocked due to odoo_import_spec None.
• T-Rex traced the reservation migration, noting that project create/cancel map to specific actions and child create/cancel map to others, while intervention reservation actions/mappings were removed and service_level was removed from sync fields.
• T-Rex reviewed the field cleanup probe and confirmed the removal of certain mapping keys, with new mappings and a simplified removed-key sample, and that nb_csp_kids and nb_cdsp_kids appear only in the updated form area.
• T-Rex examined the head evidence for legal agreement visibility and related reservation UI changes, noting legal_agreement_date, is_shown_on_public_forms, Allocated children, reservation visibility/required expressions, Events button inheritance, and absence of crm_compassion invoice/invoiced override references.

_{Ran code and verified through T-Rex}

_{Reviews (1): Last reviewed commit: "[MIG] T3067: fix tests on v18" | Re-trigger Greptile}