-
Notifications
You must be signed in to change notification settings - Fork 197
feat(Kind): add AddManifest resource for kubectl apply after cluster ready #1481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
aaronpowell
merged 25 commits into
CommunityToolkit:main
from
tamirdresher:feat/kind-with-manifest
Aug 18, 2026
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
5c80dc4
feat(Kind): add AddManifest resource for kubectl apply after cluster …
7be3aac
fix: make manifest cluster-ready timeout configurable
5d81fe0
fix: harden Helm installs for CRD races
a008d83
feat: expose Kind node config and earlier cleanup
61fff8b
docs: describe new Kind manifest and Helm options
d1f5f16
docs: show new Kind APIs in sample AppHost
c6a4ff2
docs: expand Kind API reference examples
5fe2af9
fix: broaden Kind cleanup signals
ff31891
test: verify manifest readiness timeout wiring
21d02d8
fix: normalize node mounts and helm value precedence
6b1db26
docs: clarify Kind cleanup and mount usage
9f3e530
test: make Kind node mount assertions cross-platform
ddd90d1
test: enable plain dotnet test for Kind projects
02c1973
chore: align Kind formatting and API baselines
75c0b50
docs: expand Kind XML API comments
tamirdresher 983ae85
fix: address Kind Copilot review feedback
tamirdresher 219b58c
fix: address Matt's review — node image conflict, manifest path valid…
tamirdresher 532150f
refactor: simplify Kind shutdown cleanup to ApplicationStopping only …
tamirdresher 027032b
refactor: standardize Kind retry/backoff on Microsoft.Extensions.Resi…
tamirdresher 32f6e1e
refactor: require explicit opt-in for Helm CRD-wait retry, remove aut…
tamirdresher d8d9591
refactor: move K8sManifestResource config to annotations for API evol…
tamirdresher 88606e3
refactor: fold CrdWaitBehavior into cohesive wait-policy config (per …
tamirdresher bd95376
refactor: clarify KubectlManager validation placement and resource-lo…
tamirdresher 36f508f
fix: stop redacting kubeconfig paths in debug logs (per review)
tamirdresher a58e491
Remove generated Kind API baseline
tamirdresher File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 16 additions & 0 deletions
16
examples/kind/CommunityToolkit.Aspire.Hosting.Kind.AppHost/manifests/extra-config.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| # This file demonstrates a multi-document manifest: | ||
| # 1. A Namespace for grouping demo resources. | ||
| # 2. A ConfigMap scoped to that namespace. | ||
| apiVersion: v1 | ||
| kind: Namespace | ||
| metadata: | ||
| name: aspire-demo | ||
| --- | ||
| apiVersion: v1 | ||
| kind: ConfigMap | ||
| metadata: | ||
| name: extra-config | ||
| namespace: aspire-demo | ||
| data: | ||
| greeting: hello-kind | ||
| purpose: aspire-demo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 26 additions & 0 deletions
26
src/CommunityToolkit.Aspire.Hosting.Kind/CrdWaitBehavior.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| #pragma warning disable ASPIREATS001 // AspireExport APIs are experimental | ||
|
|
||
| [assembly: Aspire.Hosting.AspireExport(typeof(Aspire.Hosting.CrdWaitBehavior))] | ||
|
|
||
| namespace Aspire.Hosting; | ||
|
|
||
| /// <summary> | ||
| /// Specifies how Kind manifest resources handle CRD Established-condition wait failures. | ||
| /// </summary> | ||
| public enum CrdWaitBehavior | ||
| { | ||
| /// <summary> | ||
| /// Fail the manifest resource when waiting for applied CRDs fails or times out. | ||
| /// </summary> | ||
| Fail, | ||
|
|
||
| /// <summary> | ||
| /// Log a warning and continue when waiting for applied CRDs fails or times out. | ||
| /// </summary> | ||
| BestEffort, | ||
| } | ||
|
|
||
| #pragma warning restore ASPIREATS001 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.