chore: import three commoner-probe modules under their current names - #97
Merged
Conversation
probe renamed three modules and kept the old names as deprecated aliases.
This package imported all three old names, so the suite ran with three
DeprecationWarnings. It now runs with none.
commoner_probe.committees -> commoner_probe.committee_report_api
commoner_probe.sansad -> commoner_probe.parliament_qa_api
commoner_probe.neva -> commoner_probe.assembly_portal
No public surface changes. Only the module this package imports FROM changes.
Every re-exported name stays as it was. Verified against probe 0.16.0: each new
module exposes an identical public surface to the one it replaces.
The four compat tests move with it, because they patched the old paths.
The old names break when probe removes them. A local run could not see the
warnings: the repo venv held probe 0.13.0 while pyproject pinned 0.16.0. The
venv is repaired.
509 passed, 1 skipped, and zero warnings.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
probe renamed three modules and kept the old names as deprecated aliases. This package imported all three old names.
commoner_probe.committeescommoner_probe.committee_report_apicommoner_probe.sansadcommoner_probe.parliament_qa_apicommoner_probe.nevacommoner_probe.assembly_portalThe suite ran with three
DeprecationWarnings. It now runs with none.No public surface changes
Only the module this package imports from changes. Every name this package re-exports stays exactly as it was.
Verified against probe 0.16.0: each new module exposes an identical public surface to the one it replaces.
committees/committee_report_apiboth expose 35 names,sansad/parliament_qa_apiboth 49,neva/assembly_portalboth 13, with nothing missing from any new module. The swap is a pure alias.The four compat tests move with it, because they patched the old paths.
Why this was invisible
The old names break when probe removes them, and the only warning was the
DeprecationWarningitself. A local run could not see it. The repo's.venvheld probe 0.13.0 whilepyproject.tomlpinned==0.16.0— three minors behind. Every localpytestthis session tested against 0.13.0.The venv is repaired. That is how the warnings became visible at all.
Tests
509 passed, 1 skipped, 12 subtests, zero warnings.