release: 2.7.1 - #96
Merged
Merged
Conversation
PATCH. One fix, no API change. REQ-0072. FEDERAL_DEFLECTION's state-subject pattern now accepts the participial form. "Agriculture being a State subject" matched nothing before. THE VERSION CANNOT CARRY THIS WARNING, SO READ IT HERE. The patch MOVES A PUBLISHED EVASION RATE, upward, in every corpus. Re-run `analyse-discourse`, then re-read every rate computed from it. A patch number implies no consequence and that implication is wrong here. Two kinds of record move. 518 previously carried no label from any tier, and they now raise both the evasive count and the classified denominator. Another 2,464 already carried a label from some other pattern, and FEDERAL_DEFLECTION's 0.92 outranks it. Where that label was substantive, the rate rises again. Version bumped in pyproject.toml, commoner_analyse/__init__.py, CITATION.cff and the seven README install lines.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PATCH — one fix, no API change
REQ-0072, merged in #95.
FEDERAL_DEFLECTION's state-subject pattern now accepts the participial form.The version number cannot carry the warning, so read it here
This patch moves a published evasion rate, upward, in every corpus.
Re-run
analyse-discourse, then re-read every rate computed from it. A patch number implies no consequence. That implication is wrong here, which is exactly why the changelog entry leads with it.Two kinds of record move
FEDERAL_DEFLECTION0.92 outranks it; where the old label was substantive, the rate rises againCounts measured by zero-hour over 489,469 answered records.
Not introduced here
The precedence that produces the second row is pre-existing. The shipped copula pattern already outranks
ACCEPTEDandREJECTEDat 0.92, over 5,542 records, before this change. Whether it should is a separate question and wants its own request.Tests
509 passed, 1 skipped, 12 subtests. Version bumped in five places.