Skip to content

fix(popup): avoid blank gap when opening via shortcut - #14

Merged
Tomlord1122 merged 1 commit into
Cometline:masterfrom
tomtom-bot7:fix/shortcut-open-blank-gap
Sep 7, 2026
Merged

Tomlord1122 merged 1 commit into
Cometline:masterfrom
tomtom-bot7:fix/shortcut-open-blank-gap

Conversation

@tomtom-bot7

Copy link
Copy Markdown
Contributor

Summary

Intermittent blank grey band under the header when opening the popup with CommandOrControl+Shift+M (list starts mid-window; company toggle / progress / search look missing).

Changes

  • Ignore blur-to-hide for ~400ms after show (shortcut keyup can steal focus and hide/reflow race)
  • Re-assert popup bounds on every open
  • Invalidate webContents + send popup-shown so the renderer resets scroll and nudges layout
  • Replace review-card inner h-full with a fixed min-height so empty chrome does not stretch

Test plan

  • Toggle popup with tray click — still works
  • Toggle repeatedly with global shortcut; confirm no blank grey band under header
  • Blur/click outside still hides after the grace window
  • Company toggle, progress, search remain visible on open

Ignore blur-to-hide briefly after show (shortcut keyup race), re-assert
window bounds, invalidate + notify the renderer to reset scroll/layout,
and drop review-card h-full that could stretch empty chrome.
@Tomlord1122
Tomlord1122 merged commit c58feb7 into Cometline:master Sep 7, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants