fix(ui): handle empty starred list without NaN - #13
Merged
Merged
Conversation
Guard progress percent when total is 0, and show a clear empty-state message (e.g. No problems starred) instead of Loading...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NaNwhen the current set has 0 problems (0/0shows0%).No problems starredfor the Starred set, filter miss message when filters are on,Loading...only while loading, otherwiseNo problems found.Test plan
0/0 practiced/0%(not NaN) andNo problems starred(not Loading...).