Repository navigation
Conversation
![staging-devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/870844?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows,
release(..., publish=False)fails withFileNotFoundError: [WinError 2]even when npm is installed:subprocess.run(["npm", ...])does not resolve thenpm.cmdshim.Resolve npm with
shutil.which()before invoking it. Add an integration test that runs a realnpm packfrom a directory containing spaces and verifies the generated package metadata, plus a Windows/Linux/macOS test workflow.Validation:
python -m unittest discover -s tests -vfails on the original code and passes with this change on Windows (Python 3.14, npm 11.17.0). The test only packs a local fixture; it does not publish or download release binaries.CI passed on Windows, Linux, and macOS with Python 3.12 and Node.js 22.