London | 26-March-SDC | Ammad Ur Rehman | Sprint 1 | Individual Shell Tools

[anosidium]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

Done all the required exercise with some stretch exercises completed

Questions

I find reading the manual pages of the commands confusing and looking them up on the internet isn’t much better either.

[SlideGauge]

Could you adjust the settings of your editor and adjust all the scripts, they are missing the trailing new line

[anosidium]

Could you adjust the settings of your editor and adjust all the scripts, they are missing the trailing new line

Thanks for the review. Before I address the rest of your comments, could you tell me a bit more about how to do this? Are you referring to the “No newline at end of file”?

My other pull requests have had the same thing, so this is the first time I’ve heard it mentioned.

[SlideGauge]

Yeah, I'm talking about

sign you have in github. The setting itself depends on the editor you use, this is an example how you do this in the VS code:
https://stackoverflow.com/questions/44704968/visual-studio-code-insert-newline-at-the-end-of-files

[anosidium]

Thanks for the review, I've amended my solutions.

[SlideGauge]

Good job review complete

[illicitonion]

Closing PR because the SDC run has finished. Feel free to re-open if you're still working on it.