Skip to content

London | 26-ITP-Sep | Anita Amirhaeri | Sprint 3 | coursework/sprint 3 - #1636

Open
anitahy73 wants to merge 27 commits into
CodeYourFuture:mainfrom
anitahy73:acoursework/sprint-3
Open

anitahy73 wants to merge 27 commits into
CodeYourFuture:mainfrom
anitahy73:acoursework/sprint-3

Conversation

@anitahy73

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Task code

CYF-1053

Changelist

oursework/sprint 3

Questions

@netlify

netlify Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 64e95e7
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6acbc6862debd40008ca0a67
😎 Deploy Preview https://deploy-preview-1636--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

@anitahy73 anitahy73 added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 1, 2026
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 1, 2026
@anitahy73 anitahy73 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 6, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 6, 2026
Removed placeholder comments and explanations in time-format.js.
@anitahy73 anitahy73 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 6, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 6, 2026
Added comments to explain the behavior of the pad function and its calls in formatTimeDisplay.
@anitahy73 anitahy73 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 6, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 6, 2026
@anitahy73 anitahy73 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 6, 2026
@abdishakoor-dev

abdishakoor-dev commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Before I can review your Sprint 3 work, this PR needs to change Sprint 3 files only. At the moment it also changes 5 Sprint 2 files, which is why the bot keeps taking the Needs Review label off:

  • Sprint-2/1-key-exercises/1-count.js
  • Sprint-2/1-key-exercises/3-paths.js
  • Sprint-2/2-mandatory-errors/4.js
  • Sprint-2/3-mandatory-interpret/1-percentage-change.js
  • Sprint-2/3-mandatory-interpret/3-to-pounds.js

Your Sprint 2 work is already completed. It's in your Sprint 2 PR (#1553), which is already marked Complete. So we can simply remove the Sprint 2 files from this PR:

  1. Open the project in VS Code. In the bottom-left corner, check the branch name says acoursework/sprint-3. If it doesn't, click it and pick acoursework/sprint-3 from the list.
  2. Open a terminal: Terminal menu, then New Terminal.
  3. Copy and paste these lines one at a time, pressing Enter after each:
git pull
git fetch https://github.com/CodeYourFuture/Module-JavaScript-Fundamentals.git main
git checkout FETCH_HEAD -- Sprint-2
git commit -m "Remove Sprint-2 changes from this PR"
git push
  1. Refresh this page and click the Files changed tab at the top. You should see only Sprint-3 files (10 of them), and no Sprint-2 files.
  2. Add the Needs Review label again. This time it will stay.

If anything looks different from what I've described, or you get an error, post a screenshot here and I'll help you through it.

@abdishakoor-dev abdishakoor-dev added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 6, 2026
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@anitahy73 anitahy73 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 11, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 11, 2026
@anitahy73 anitahy73 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 3 Assigned during Sprint 3 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants