Repository navigation
Conversation
Added comments to explain variable declaration and assignment.
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Removed placeholder comments and explanations in time-format.js.
This comment has been minimized.
This comment has been minimized.
Added comments to explain the behavior of the pad function and its calls in formatTimeDisplay.
This comment has been minimized.
This comment has been minimized.
Contributor
|
Before I can review your Sprint 3 work, this PR needs to change Sprint 3 files only. At the moment it also changes 5 Sprint 2 files, which is why the bot keeps taking the Needs Review label off:
Your Sprint 2 work is already completed. It's in your Sprint 2 PR (#1553), which is already marked Complete. So we can simply remove the Sprint 2 files from this PR:
If anything looks different from what I've described, or you get an error, post a screenshot here and I'll help you through it. |
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Removed duplicate comment and fixed typo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Learners, PR Template
Self checklist
Task code
CYF-1053
Changelist
oursework/sprint 3
Questions