Repository navigation
London | 26-SDC-July | Raihan Sharif | Sprint 3 | Middleware exercises - #128
Open
RaihanSharif wants to merge 55 commits into
Open
RaihanSharif wants to merge 55 commits into
RaihanSharif wants to merge 55 commits into
Conversation
Can post message, with validation. Can get all messages.
Only return list of messages, or a single message. Clean up js doc
Messages can now be fetched or created using REST API. Client can then fetch subsequent messages using event streaming.
create new message handling function.
... but don't add to local messages map. That will be done by the event polling.
Websocket version only has websocket code, everything else is in a separate file that can be reused by polling version.
Extract common code for the web socket and polling versions.
RaihanSharif
added
the
Needs Review
Poonam-raj
added
Review in progress
Poonam-raj
reviewed
Oct 13, 2026
Poonam-raj
reviewed
Oct 13, 2026
Poonam-raj
reviewed
Oct 13, 2026
Poonam-raj
reviewed
Oct 13, 2026
Poonam-raj
reviewed
Oct 13, 2026
Poonam-raj
reviewed
Oct 13, 2026
Poonam-raj
left a comment
Poonam-raj
left a comment
There was a problem hiding this comment.
I'd like you to remove the work you did on the chat app from this branch - make it separate, this work is solely about the middleware work
Great work otherwise, I've left some comments and then one additional thought here:
- you have package files within each middleware folder but they are almost identical in purpose (marking express as a dependency). Can you make your package files sit higher in the repo so only one copy of those npm-related files needs to be created?
Poonam-raj
added
Reviewed
Author
|
I have made all changes requested in the review. |
RaihanSharif
added
Needs Review
Poonam-raj
reviewed
Oct 14, 2026
Poonam-raj
left a comment
Poonam-raj
left a comment
There was a problem hiding this comment.
fab work thank you for these changes
Poonam-raj
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Task code
CYF-1165
Changelist
First write custom middleware for processing username and request body. Then use built-in body parsers. Explain why the request has to change when using built-in middleware.