Repository navigation
Manchester | 26-Jun-SDC | Fithi Teklom | Sprint 3 | Middleware exercise - #127
Open
Fithi-Teklom wants to merge 4 commits into
Open
Fithi-Teklom wants to merge 4 commits into
Fithi-Teklom wants to merge 4 commits into
Conversation
Fithi-Teklom
added
the
Needs Review
Poonam-raj
added
Review in progress
Poonam-raj
reviewed
Oct 13, 2026
|
|
||
| app.post("/", usernameMiddleware, validateSubjects, (req, res) => { | ||
| res.send( | ||
| `Username: ${req.username}\nSubjects: ${req.body.join(", ")}` |
There was a problem hiding this comment.
We're looking for a response that looks like
You are authenticated as Ahmed.
You have requested information about 4 subjects: Birds, Bats, Lizards, Bees.
Amend this response to reflect that
Poonam-raj
reviewed
Oct 13, 2026
There was a problem hiding this comment.
We're looking for responses that look a specific way - specified in the coursework prep
Please amend your responses to reflect these instructions
Poonam-raj
reviewed
Oct 13, 2026
Comment on lines
+21
to
+25
| return res | ||
| .status(400) | ||
| .send("Request body must be a JSON array of strings."); | ||
| } | ||
|
|
There was a problem hiding this comment.
Some good additional reading would be on error handling middleware
this is an express middleware which specifically handles error - and we can use it to specifically point Express to a specific function when a error occurs, skipping anything else.
Poonam-raj
reviewed
Oct 13, 2026
|
|
||
| req.on("end", () => { | ||
| try { | ||
| const body = JSON.parse(Buffer.concat(chunks).toString("utf8")); |
There was a problem hiding this comment.
What does the Buffer.concat.toString argument do?
Poonam-raj
reviewed
Oct 13, 2026
Poonam-raj
left a comment
Poonam-raj
left a comment
There was a problem hiding this comment.
Few notes to work on here:
- Make sure you're following the response we're expecting. Both middleware examples need their responses edited to reflect what the prep material expects.
- You have nested package files and gitignores within each middleware directory when they are both identical - can we bring this higher up in the module repo to enable us to only run
npm ionce when we load the repo? And reduce how many files we're adding.
Some great express mini apps though, nice work so far
Poonam-raj
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Task code
CYF-1165