Skip to content

Birmingham | 26-Jul-SDC | Merve Reis | Sprint 3 | Middleware CYF-1165 - #123

Open
mervereis wants to merge 12 commits into
CodeYourFuture:mainfrom
mervereis:sprint3-middleware-exercises
Open

Birmingham | 26-Jul-SDC | Merve Reis | Sprint 3 | Middleware CYF-1165#123
mervereis wants to merge 12 commits into
CodeYourFuture:mainfrom
mervereis:sprint3-middleware-exercises

Conversation

@mervereis

@mervereis mervereis commented Sep 17, 2026 •
edited
Loading

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

CYF-1165

wrote two new middleware demonstrating Express middleware.

@mervereis
feat: initialize backend and frontend for group chat application
1c935a0 
- Added backend with Express server and message handling routes
- Implemented message sending, fetching, and reacting functionalities
- Created frontend HTML structure for chat interface
- Developed JavaScript for message rendering and user interactions
- Styled chat application with CSS for better user experience
@mervereis
feat: add Dockerfile for backend setup
649db14
@mervereis
feat: implement long-polling for message retrieval and update message…
39df628 
… handling
@mervereis
fix: update CORS configuration to remove unused origins
c22864b
@mervereis
fix: update server and client URLs for deployment
835930f
@mervereis
fix: improve message filtering and update handling in polling function
d164cad
@mervereis
feat: initialize backend and frontend for chat application
f000da2 
- Added package.json for backend with necessary dependencies (express, cors, crypto).
- Implemented server.js for handling message retrieval, sending, and reactions with long-polling support.
- Created index.html for the frontend chat interface with a message input area and display for chat messages.
- Developed script.js to manage message fetching, sending, and user interactions (like, dislike, reply).
- Styled the chat application with style.css for a user-friendly interface.
@mervereis
chore: add package.json for middleware-exercises with express dependency
3cb67fb
@mervereis
Remove unnecessary backend and frontend
8eda15a
@github-actions

This comment has been minimized.

Sign in to view
@mervereis mervereis added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 17, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 17, 2026
@github-actions

This comment has been minimized.

Sign in to view
3 similar comments
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@mervereis mervereis changed the title Birmingham | 26-Jul-SDC | Merve Reis | Sprint3 | middleware exercises Birmingham | 26-Jul-SDC | Merve Reis | Sprint 3 | middleware exercises Sep 17, 2026
@github-actions

This comment has been minimized.

Sign in to view
@mervereis mervereis changed the title Birmingham | 26-Jul-SDC | Merve Reis | Sprint 3 | middleware exercises Birmingham | 26-Jul-SDC | Merve Reis | Sprint 3 | middleware exercises | CYF-1165 Sep 17, 2026
@github-actions

This comment has been minimized.

Sign in to view
@mervereis mervereis changed the title Birmingham | 26-Jul-SDC | Merve Reis | Sprint 3 | middleware exercises | CYF-1165 Birmingham | 26-Jul-SDC | Merve Reis | Sprint 3 | middleware exercises CYF-1165 Sep 17, 2026
@github-actions

This comment has been minimized.

Sign in to view
@mervereis mervereis changed the title Birmingham | 26-Jul-SDC | Merve Reis | Sprint 3 | middleware exercises CYF-1165 Birmingham | 26-Jul-SDC | Merve Reis | Sprint 3 | Middleware CYF-1165 Sep 17, 2026
@mervereis mervereis added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 17, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 17, 2026
@github-actions

This comment has been minimized.

Sign in to view
@mervereis mervereis added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 17, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 17, 2026
@github-actions

This comment has been minimized.

Sign in to view
2 similar comments
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@mervereis mervereis added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 17, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 17, 2026
@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
@mervereis mervereis added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 17, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 17, 2026
@github-actions

This comment has been minimized.

Sign in to view
@mervereis mervereis added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 17, 2026
LonMcGregor
LonMcGregor reviewed Oct 7, 2026
View reviewed changes

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start on this task, apologies for the late review.

I've spotted a couple of areas you could look at again, see my comments below.

Comment thread middleware-exercises/Custom-Middleware.js Outdated

if (req.username) {
res.send(
`You are authenticated as ${req.username}.\n\n` +

@LonMcGregor LonMcGregor Oct 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given these messages are quite similar, could you rework the if block to reduce the code duplication?

@mervereis mervereis Oct 12, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed the response text was duplicated. I’ve refactored it so only the authentication message is conditional, and the shared subject information is sent once. Thanks for the suggestion. @LonMcGregor

Comment thread middleware-exercises/Off-shell-middlewares.js
next();
}

app.use(express.json());

@LonMcGregor LonMcGregor Oct 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does express.json() do all of the checks you did in your original code?

@mervereis mervereis Oct 12, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

express.json() handles parsing and malformed JSON, but it doesn’t validate the expected structure. I’ve added a middleware after it that checks the body is an array of strings and returns 400 if it isn’t.Thanks @LonMcGregor

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 7, 2026
LonMcGregor
LonMcGregor reviewed Oct 13, 2026
View reviewed changes

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, this task is complete now

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LonMcGregor LonMcGregor LonMcGregor left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mervereis @LonMcGregor