Sheffield | ITP-Jan-26 | Hayriye Saricicek | Sprint 3 | Quote Generator by mshayriyesaricicek · Pull Request #1151 · CodeYourFuture/Module-Data-Groups

mshayriyesaricicek · 2026-03-30T14:55:35Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Added a function to enable random quotes to be generated by pressing the new quote buttons.
Added style to the page by updated HTML.

jayshreehajgude2012

Nice styling but use externally.
Java script file linked correctly.
DOM methods used correctly.
Resolve Error-quotes array missing.

jayshreehajgude2012 · 2026-04-05T13:13:59Z

Sprint-3/quote-generator/index.html

+        padding: 10px 20px;
+        font-size: 16px;
+      }
+    </style>


You can use external CSS file and link it to CSS to make code clean.

I didn't see the css file that is why I did in html. I have put all styling in css now and linked in the html. Thank you.

jayshreehajgude2012 · 2026-04-05T13:14:51Z

Sprint-3/quote-generator/index.html

+        font-size: 16px;
+      }
+    </style>
    <script defer src="quotes.js"></script>


Correctly linked JavaScript file.

jayshreehajgude2012 · 2026-04-05T13:21:21Z

Sprint-3/quote-generator/quotes.js

@@ -1,3 +1,20 @@
+// DO NOT EDIT ABOVE HERE
+window.addEventListener("DOMContentLoaded", () => {


You used DOMContentLoaded properly
Clean DOM selection
Good use of textContent
Proper event listener used.
You can explore more DOM selection and Event handling methods.

jayshreehajgude2012 · 2026-04-05T13:21:58Z

Sprint-3/quote-generator/quotes.js

+  const newQuoteBtn = document.getElementById("new-quote");
+
+  function displayRandomQuote() {
+    const randomQuote = pickFromArray(quotes);


Quote Array is missing look into it.

I am not sure if you are referring to the qoute array being defined after the function that uses it? I understood that we had to write our code above the line that says do not edit below so that is what I did. Or is there something else that I am missing? Thank you

@mshayriyesaricicek does it currently work as you have it here? the quotes variable is only defined later on line 41 so the function is not able to work with quotes. The comment // DO NOT EDIT BELOW HERE is a bit misleading sorry

Hi Kyle, thank you for getting back to me. The original code referenced variables and functions before they were defined and although the defer attribute allowed it to work at runtime, I understand that this is not best practice. The code has now been restructured so that dependencies (quotes and pickFromArray) are defined before being used, improving readability and maintainability. Thank you

thanks looks good

mshayriyesaricicek · 2026-04-11T10:10:05Z

Hi Jay

Please can you review my pull request as I need it to be complete to pass Step 3. This is the only thing outstanding.

I have looked carefully at my programme and the Quotes Array is at the bottom of quotes.js I am not sure if you are wanting me to explain that the pickFromArray(quotes) function is called before quotes is defined and that this is not an issue because in html I have 'defer' so everything will be loaded before the function is performed therefore the prorgramme runs correctly.

updated function and styled in html

1a42b39

mshayriyesaricicek added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Groups The name of the module. labels Mar 30, 2026

mshayriyesaricicek mentioned this pull request Mar 30, 2026

Sheffield | ITP-Jan-26 | Data Groups | Hayriye Saricicek mshayriyesaricicek/My-Coursework-Planner#145

Open

jayshreehajgude2012 added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Apr 5, 2026

jayshreehajgude2012 reviewed Apr 5, 2026

View reviewed changes

jayshreehajgude2012 added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Apr 5, 2026

mshayriyesaricicek removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 5, 2026

moved styling from html to css

e4ad56d

mshayriyesaricicek added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Apr 5, 2026

some lines were missing on local copy so updated local copy

29bc293

kyle-tightest added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 11, 2026

Restructured code so dependencies are defined before being used.

3151ee1

mshayriyesaricicek added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 12, 2026

kyle-tightest added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 13, 2026

		@@ -1,3 +1,20 @@
		// DO NOT EDIT ABOVE HERE
		window.addEventListener("DOMContentLoaded", () => {

Uh oh!

Conversation

mshayriyesaricicek commented Mar 30, 2026

Changelist

Uh oh!

jayshreehajgude2012 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mshayriyesaricicek Apr 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mshayriyesaricicek commented Apr 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mshayriyesaricicek Apr 11, 2026 •

edited

Loading