London | 26-ITP-Jan | Karla Grajales | Sprint 2 | Book Library #416
London | 26-ITP-Jan | Karla Grajales | Sprint 2 | Book Library #416Grajales-K wants to merge 30 commits intoCodeYourFuture:mainfrom
Conversation
and passing as parameter index directly in the event to avoid overlapping, delButton eventListener
This comment has been minimized.
This comment has been minimized.
Grajales-K
added
Needs Review
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Can you check if any of this general feedback can help you further improve your code?
https://github.com/CodeYourFuture/Module-Data-Flows/blob/general-review-feedback/debugging/book-library/feedback.md
Doing so can help me speed up the review process. Thanks.
cjyuan
added
Reviewed
- remove static <tr> tags, generated by Dom and. - fix: id in the opening tag <tbody>
…for loop delete to clear the table before to render
…r better usability
…out and usability
Grajales-K
added
the
Needs Review
I have made a lot of changes, and I hope they are better now. Thank you! |
| const titleVal = titleInput.value.trim(); | ||
| const authorVal = authorInput.value.trim(); | ||
| const pagesVal = pagesInput.value; | ||
|
|
||
| if (!titleVal || !authorVal || pagesVal <= 0) { | ||
| alert("Please fill the field with valid info!"); | ||
| return; |
There was a problem hiding this comment.
Note: pagesInput.value is a string.
Your code can still work correctly, but best practice is to sanitise/normalise the input to proper data type first before using them.
| background-color: #117a8b !important; | ||
| border-color: #10707f !important; | ||
| color: #fff !important; |
There was a problem hiding this comment.
CSS is designed around specificity and order.
Using !important in CSS is generally considered a last resort, not a standard practice.
Is there any reason you choose to use !important?
cjyuan
added
Complete
2 participants
Learners, PR Template
Self checklist
Changelist
This project provided a valuable opportunity for debugging; I checked the project and used the devtools to identify and fix the errors.