Skip to content

London|ITP-Jan-2026 |Ping Wang | Sprint 2 | Book library#408

Open
pathywang wants to merge 7 commits intoCodeYourFuture:mainfrom
pathywang:book-library
Open

London|ITP-Jan-2026 |Ping Wang | Sprint 2 | Book library#408
pathywang wants to merge 7 commits intoCodeYourFuture:mainfrom
pathywang:book-library

Conversation

@pathywang
Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

After i have done my PREP, I set up my own branch from main and did quite a few commit and push in order to complete this PR with AI help.Quite challenge for me

@pathywang pathywang added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 6, 2026
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check if any of this general feedback can help you further improve your code?
https://github.com/cjyuan/Module-Data-Flows/blob/book-library-feedback/debugging/book-library/feedback.md

Doing so can help me speed up the review process. Thanks.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 7, 2026
@pathywang
Copy link
Copy Markdown
Author

i did check index.html with validator and correct some my script.js according feedback.md. i did get some AL help

@pathywang pathywang added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Apr 8, 2026
@cjyuan
Copy link
Copy Markdown
Contributor

cjyuan commented Apr 8, 2026

Looks good. Well done.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants