London | 26-ITP-Jan | Oussama Mouggal | Sprint 2 | Book-Library#397
Open
Oussama-Mouggal wants to merge 9 commits intoCodeYourFuture:mainfrom
Open
London | 26-ITP-Jan | Oussama Mouggal | Sprint 2 | Book-Library#397Oussama-Mouggal wants to merge 9 commits intoCodeYourFuture:mainfrom
Oussama-Mouggal wants to merge 9 commits intoCodeYourFuture:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
Oussama-Mouggal
changed the title
Oussama-Mouggal
added
the
Needs Review
cjyuan
reviewed
Apr 4, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Can you check if any of this general feedback can help you further improve your code?
https://github.com/cjyuan/Module-Data-Flows/blob/book-library-feedback/debugging/book-library/feedback.md
Doing so can help me speed up the review process. Thanks.
cjyuan
added
Reviewed
Author
|
Thank you @cjyuan for your feedback, and sorry I haven't referred to the feedback.md doc before submitting. I have now changed the code, so I hope it's improved for review. Thank you |
Oussama-Mouggal
added
the
Needs Review
cjyuan
reviewed
Apr 5, 2026
cjyuan
removed
the
Needs Review
Oussama-Mouggal
added
the
Needs Review
Contributor
|
Changes look good. Well done. |
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist:
I fixed the bugs in the code and corrected the syntax