Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion Sprint-2/improve_with_caches/fibonacci/fibonacci.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,15 @@

cache = {}


def fibonacci(n):
if n in cache:
return cache[n]

if n <= 1:
return n
return fibonacci(n - 1) + fibonacci(n - 2)

result = fibonacci(n - 1) + fibonacci(n - 2)
cache[n] = result

return result
39 changes: 27 additions & 12 deletions Sprint-2/improve_with_caches/making_change/making_change.py
Original file line number Diff line number Diff line change
@@ -1,32 +1,47 @@

from typing import List


def ways_to_make_change(total: int) -> int:
"""
Given access to coins with the values 1, 2, 5, 10, 20, 50, 100, 200, returns a count of all of the ways to make the passed total value.
cache = {}
coins = [200, 100, 50, 20, 10, 5, 2, 1]

return ways_to_make_change_helper(total, coins, cache)

For instance, there are two ways to make a value of 3: with 3x 1 coins, or with 1x 1 coin and 1x 2 coin.
"""
return ways_to_make_change_helper(total, [200, 100, 50, 20, 10, 5, 2, 1])

def ways_to_make_change_helper(
total: int, coins: List[int], cache: dict
) -> int:
if total == 0:
return 1

def ways_to_make_change_helper(total: int, coins: List[int]) -> int:
"""
Helper function for ways_to_make_change to avoid exposing the coins parameter to callers.
"""
if total == 0 or len(coins) == 0:
if len(coins) == 0:
return 0

key = (total, tuple(coins))

if key in cache:
return cache[key]

ways = 0

for coin_index in range(len(coins)):
coin = coins[coin_index]
count_of_coin = 1

while coin * count_of_coin <= total:
total_from_coins = coin * count_of_coin

if total_from_coins == total:
ways += 1
else:
intermediate = ways_to_make_change_helper(total - total_from_coins, coins=coins[coin_index+1:])
ways += intermediate
ways += ways_to_make_change_helper(
total - total_from_coins,
coins[coin_index + 1:],
cache,
)
Comment on lines +21 to +42

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Array and tuple creations are relatively costly operations.

We could observe that coins can only be one of the following 9 arrays:

[200, 100, 50, 20, 10, 5, 2, 1]
[100, 50, 20, 10, 5, 2, 1]
[50, 20, 10, 5, 2, 1]
...
[1]
[]

We could further improve the performance if we can

  • avoid repeatedly creating the same sub-arrays at line 40 (e.g. use another cache), and
  • create key as (total, a_unique_integer_identifying_the_subarray) instead of as (total, tuple of coins)
    • There are only a small number of different subarrays. We can easily assign each subarray a unique integer.


count_of_coin += 1

cache[key] = ways
return ways
Loading