Birmingham | 26-Jul-SDC | Merve Reis | Sprint 2 | improve with precomputing

Sprint-2/improve_with_precomputing/common_prefix/common_prefix.py

@@ -1,24 +1,28 @@
 from typing import List
 
 
-def find_longest_common_prefix(strings: List[str]):
-    """
-    find_longest_common_prefix returns the longest string common at the start of any two strings in the passed list.
+def find_longest_common_prefix(strings: List[str]) -> str:
+    if len(strings) < 2:
+        return ""
+
+    strings = sorted(strings)
 
-    In the event that an empty list, a list containing one string, or a list of strings with no common prefixes is passed, the empty string will be returned.
-    """
     longest = ""
-    for string_index, string in enumerate(strings):
-        for other_string in strings[string_index+1:]:
-            common = find_common_prefix(string, other_string)
-            if len(common) > len(longest):
-                longest = common
+
+    for i in range(len(strings) - 1):
+        common = find_common_prefix(strings[i], strings[i + 1])
+
+        if len(common) > len(longest):
+            longest = common
+
     return longest
 
 
 def find_common_prefix(left: str, right: str) -> str:
     min_length = min(len(left), len(right))
+
     for i in range(min_length):
         if left[i] != right[i]:
             return left[:i]
+
     return left[:min_length]

Sprint-2/improve_with_precomputing/count_letters/count_letters.py

@@ -1,14 +1,13 @@
 def count_letters(s: str) -> int:
-    """
-    count_letters returns the number of letters which only occur in upper case in the passed string.
-    """
-    only_upper = set()
+    upper = set()
+    lower = set()
+
     for letter in s:
-        if is_upper_case(letter):
-            if letter.lower() not in s:
-                only_upper.add(letter)
-    return len(only_upper)
+        if letter.isupper():
+            upper.add(letter)
+        elif letter.islower():
+            lower.add(letter)
 
+    only_upper = upper - {letter.upper() for letter in lower}
 
-def is_upper_case(letter: str) -> bool:
-    return letter == letter.upper()
+    return len(only_upper)