Repository navigation
London | 26-Jul_SDC | Shaghayegh Far| Sprint 1 | Analyse and Refactor Functions - #243
Open
shaghayeghfar wants to merge 1 commit into
Open
shaghayeghfar wants to merge 1 commit into
shaghayeghfar wants to merge 1 commit into
Conversation
shaghayeghfar
added
the
Needs Review
illicitonion
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Task code
CYF-1173
Changelist
In Sprint 1, I improved four JavaScript functions by reducing unnecessary loops and using Set to make searching and removing duplicates faster. I also added comments explaining the time and space complexity and ran tests to check that the code worked correctly.