London | 26-Jul_SDC | Roman Sanaye | Sprint 1 | Analyse and Refactor Functions

[RomanSanaye]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Task code

CYF-1173

Changelist

Analysed and refactored the JavaScript functions in Sprint 1 to reduce their complexity, and documented the complexity before and after in each docblock:

• calculateSumAndProduct: merged two loops into one. Still O(n) time, O(1) space.
• findCommonItems: replaced includes inside filter with a Set lookup. Time O(n × m) to O(n + m).
• hasPairWithSum: replaced nested loops with a Set of visited numbers. Time O(n²) to O(n).
• removeDuplicates: replaced nested loops with [...new Set(inputSequence)]. Time O(n²) to O(n).

[cjyuan]

Analyses and code are good.

Could you ensure all code are consistently formatted?

[RomanSanaye]

Hi @cjyuan ,
Thanks for the feedback! I've updated the PR with consistent formatting across all files. Ready for another look whenever you're free!

[cjyuan]

Changes look good. Well done.