Repository navigation
ci: run tests on 4.x and fix the test matrix - #223
Closed
CodeWithDennis wants to merge 2 commits into
Closed
CodeWithDennis wants to merge 2 commits into
CodeWithDennis wants to merge 2 commits into
Conversation
- Trigger on pushes and PRs to 4.x (main does not exist) - Drop PHP 8.1 (composer.json requires ^8.2) - Replace Laravel 10 with 11: filament/forms ^4|^5 requires illuminate ^11.28 - Set testbench and carbon for every Laravel row (11 -> 9.*, 12 -> 10.*, 13 -> 11.*) - Disable fail-fast so every failing combination is reported
Every Laravel 11 release has unpatched security advisories (EOL), so Composer's default advisory blocking makes the 11.* rows unresolvable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test workflow only triggered on
main, which doesn't exist, so pushes and PRs to4.x(e.g. #222) never got any checks.Changes to
run-tests.ymlpushandpull_requestto4.x.composer.jsonrequiresphp: ^8.2.filament/forms^4/^5 requiresilluminate/contracts ^11.28.policy.advisories.block), socomposer updatefails for all 11.* rows. Testing it would mean turning that protection off in CI.testbenchandcarbonfor every Laravel row. Before, only the Laravel 10 row had them, so the 12.* and 13.* rows rancomposer require "orchestra/testbench:"with an empty constraint.10.*, carbon^3.8.411.*, carbon^3.8.4(excluded on PHP 8.2, since Laravel 13 / testbench 11 need PHP 8.3+)fail-fast: false, so every failing combination shows up instead of being cancelled.fix-php-code-styling.ymlanddependabot-auto-merge.ymlhave no branch filter, so they need no change.Resolution check
I dry-ran
composer updatelocally withconfig.platform.phpset, for both this branch'scomposer.jsonand the one from #222 (Pest^5.0):So adding Pest 5 in #222 doesn't break older PHP versions; they keep resolving to Pest 3/4.
composer.jsonstill advertisesilluminate/contracts ^10.0|^11.0andorchestra/testbench ^8.0|^9.0. Removing those is a separate decision, so this PR doesn't touch them.