Repository navigation
Conversation
GraemeF
force-pushed
the
fix/pubsub-capacity
branch
from
September 30, 2026 16:29
99e110a to
bcd776e
Compare
GraemeF
changed the title
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The in-memory store sized its subscription buffers with
2 ^ 8, which is 10 in JavaScript, not the 256 the code meant. A subscriber ten events behind blockedappendwhile it held the store lock, so a consumer that appended to a stream it was subscribed to could deadlock.The buffers stay bounded, now at 256. A subscriber 256 events behind still blocks
append. That is deliberate: the store is for tests and similar uses, where failing beats consuming all memory.The test lags a subscriber 100 events behind, past ten but under 256, and shows appends still complete. It times out against
2 ^ 8.