Repository navigation
Refuse a message body the realm would clip - #333
Merged
Merged
Conversation
Zulip cuts a body past its max_message_length and still answers success, so a long post read back truncated while the sender saw it succeed. The Zulip adapter now reads the realm's limit once and fails post and edit with a typed MessageRejected before sending. The memory adapter takes a configurable limit so the shared contract suite asserts the refusal.
GraemeF
force-pushed
the
worktree-comms-fae1
branch
from
October 22, 2026 10:42
8595849 to
b9f6b9e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zulip cuts a message body that passes the realm's
max_message_lengthand still answers success. A long post then reads back truncated while the sender sees it succeed. commy added nothing on either path, so the cut is the realm's.The Zulip adapter now reads the realm's limit once from
/registerand failspostandeditwith a new typedMessageRejectedbefore anything is sent. It counts code points, as Zulip does. The memory adapter takes a configurable limit. The post tool description tells an agent to split a long body.The refusal is port behaviour, so it is tested in the shared contract (
postingandpublishermodules) and runs against the memory adapter and the Zulip adapter on the in-process realm. The contract env gainsmessageLengthLimit, and the in-process realm reportsmax_message_lengthfrom/register. The Zulip adapter suite keeps only its own mechanics: counting in code points and reading the limit once.