Repository navigation
Conversation
A bare bd ready leaves gates out as work nobody claims, so bdi read every gate as not ready. bdi now also asks bd ready --type gate, which answers for gates by bd's own rule, and adds those ids to the ready set.
# Conflicts: # src/collect/bd.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bare
bd readyleaves gates out as work nobody claims, so bdi read every gate as not ready, even one with no open blocker. bd answers for gates by its own rule when asked by type, so bdi now also asksbd ready --type gateand adds those ids to the ready set. Ready keeps bd's meaning, and a gate gets no rendering of its own.The two calls run at the same time rather than one after the other.